Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Pinning numpy version in setup.py #57

Merged
merged 9 commits into from
Jun 21, 2024
Merged

FIX: Pinning numpy version in setup.py #57

merged 9 commits into from
Jun 21, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Jun 20, 2024 •
edited
Loading

Description
FIX: Pins numpy and netcdf5 versions to avoid API issues.

Tested in the dependent repositories pace, pyFV3, and pySHiELD.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino marked this pull request as ready for review June 20, 2024 20:08
@fmalatino fmalatino changed the title Pinning numpy version in setup.py FIX: Pinning numpy version in setup.py Jun 20, 2024
gmao-ckung
gmao-ckung previously approved these changes Jun 20, 2024
View reviewed changes
mlee03
mlee03 reviewed Jun 21, 2024
View reviewed changes
.github/workflows/unit_tests.yaml Outdated
@@ -25,6 +25,7 @@ jobs:
run: |
python -m pip install --upgrade pip setuptools wheel
pip install .[test]
pip list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this pip list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anymore. I will remove it now

@fmalatino fmalatino requested review from mlee03 and gmao-ckung June 21, 2024 11:50
oelbert
oelbert approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmalatino fmalatino merged commit d6f39c1 into NOAA-GFDL:develop Jun 21, 2024
2 checks passed
@fmalatino fmalatino deleted the fix/numpy branch June 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-ckung gmao-ckung gmao-ckung approved these changes

@mlee03 mlee03 mlee03 approved these changes

@oelbert oelbert oelbert approved these changes

@xyuan xyuan xyuan approved these changes

@FlorianDeconinck FlorianDeconinck Awaiting requested review from FlorianDeconinck

@bensonr bensonr Awaiting requested review from bensonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmalatino @xyuan @oelbert @mlee03 @gmao-ckung