Quantity factory to use dsl Float type as default #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmalatino
changed the title
fmalatino
force-pushed
the
fix/float_precision
branch
from
32dc434 to
b87f813
Compare
fmalatino
requested review from
FlorianDeconinck,
xyuan,
mlee03,
oelbert and
bensonr
bensonr
previously approved these changes
May 24, 2024
oelbert
requested changes
May 25, 2024
ndsl/quantity.py
Outdated
| @@ -298,7 +300,7 @@ def __init__( | |||
| """ | |||
| # ToDo: [Florian 01/23] Kill the abomination. | |||
| # See https://github.com/NOAA-GFDL/pace/issues/3 | |||
| from ndsl.dsl.typing import Float | |||
| # from ndsl.dsl.typing import Float | |||
There was a problem hiding this comment.
I'd rather delete this instead of commenting it out
There was a problem hiding this comment.
Double check that all build are fine with removing the workaround and then, indeed, remove all comments.
There was a problem hiding this comment.
I have tested these changes in the following ways:
- Test branch in pyFV3 (develop)
- python=3.8
- translate numpy passes
- translate dace:cpu passes
- python=3.11
- translate numpy passes
- translate dace:cpu passes
- python=3.8
- Test branch in pySHiELD (develop)
- python=3.8
- translate numpy passes
- translate dace:cpu passes
- python=3.11
- translate numpy passes
- translate dace:cpu passes
- python=3.8
- Test branch in pace (develop)
- python=3.8
- tests/main passed
- python=3.11
- tests/main passed
- python=3.8
xyuan
previously approved these changes
May 25, 2024
FlorianDeconinck
requested changes
May 29, 2024
ndsl/quantity.py
Outdated
| @@ -298,7 +300,7 @@ def __init__( | |||
| """ | |||
| # ToDo: [Florian 01/23] Kill the abomination. | |||
| # See https://github.com/NOAA-GFDL/pace/issues/3 | |||
| from ndsl.dsl.typing import Float | |||
| # from ndsl.dsl.typing import Float | |||
There was a problem hiding this comment.
Double check that all build are fine with removing the workaround and then, indeed, remove all comments.
ndsl/quantity.py
Outdated
| @@ -298,7 +300,6 @@ def __init__( | |||
| """ | |||
| # ToDo: [Florian 01/23] Kill the abomination. | |||
| # See https://github.com/NOAA-GFDL/pace/issues/3 | |||
There was a problem hiding this comment.
Remove this before merging
FlorianDeconinck
previously approved these changes
May 31, 2024
FlorianDeconinck
approved these changes
May 31, 2024
bensonr
approved these changes
May 31, 2024
xyuan
approved these changes
Jun 3, 2024
mlee03
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to
QuantityFactorymethods that previosuly defaulted tonumpy.float64type to useFloatdsl type to enable specification of 32-bit or 64-bit precision.How Has This Been Tested?
Tested using currently implemented unit tests
Use in builds of
pyFV3,pySHiELD, andpaceChecklist: