Skip to content

Commit

Permalink
MOM6: Fix logic for reading parameter in MOM_tracer_advect.F90
Browse files Browse the repository at this point in the history 
- NOAA-GFDL/MOM6@90749f30f Fix logic for reading parameter in MOM_tracer_advect.F90
  • Loading branch information
@mom6bot @adcroft
mom6bot authored and adcroft committed Jul 31, 2024
1 parent b44fbd3 commit 5bbcb80
Show file tree
Hide file tree
Showing 21 changed files with 1 addition and 81 deletions.
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/cooling_only/BML/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/cooling_only/EPBL/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/cooling_only/KPP/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/mech_only/BML/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/mech_only/EPBL/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/mech_only/KPP/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/skin_warming_wind/BML/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/skin_warming_wind/EPBL/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/skin_warming_wind/KPP/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/wind_only/BML/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/wind_only/EPBL/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/CVmix_SCM_tests/wind_only/KPP/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/DOME/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1464,10 +1464,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 0.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/SCM_idealized_hurricane/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,10 +1457,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/circle_obcs/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1529,10 +1529,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 0.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/single_column/BML/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1463,10 +1463,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/single_column/EPBL/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1610,10 +1610,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/single_column/KPP/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1532,10 +1532,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 600.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/torus_advection_test/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1421,10 +1421,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 0.0 ! [m2 s-1] default = 0.0
Expand Down
4 changes: 0 additions & 4 deletions ocean_only/unit_tests/MOM_parameter_doc.all
View file
Original file line number Diff line number Diff line change
Expand Up @@ -904,10 +904,6 @@ TRACER_ADVECTION_SCHEME = "PLM" ! default = "PLM"
! PLM - Piecewise Linear Method
! PPM:H3 - Piecewise Parabolic Method (Huyhn 3rd order)
! PPM - Piecewise Parabolic Method (Colella-Woodward)
USE_HUYNH_STENCIL_BUG = False ! [Boolean] default = False
! If true, use a stencil width of 2 in PPM:H3 tracer advection. This is
! incorrect and will produce regressions in certain configurations, but may be
! required to reproduce results in legacy simulations.

! === module MOM_tracer_hor_diff ===
KHTR = 0.0 ! [m2 s-1] default = 0.0
Expand Down
2 changes: 1 addition & 1 deletion src/MOM6
Submodule MOM6 updated 1 files
+4 −2 src/tracer/MOM_tracer_advect.F90

0 comments on commit 5bbcb80

Please sign in to comment.