Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRFS-MPAS: Various fixes and enhancements #1109

Merged
merged 10 commits into from
Jan 13, 2025
Merged

RRFS-MPAS: Various fixes and enhancements #1109

merged 10 commits into from
Jan 13, 2025

Conversation

jaymes-kenyon
Copy link
Contributor

This PR addresses issue #1108 for RRFS-MPAS applications. It provides the following changes:

  1. Temporary hard coding of imp_physics=8 for RRFS-MPAS, as required for brightness-temperature calculations in subroutine CALRAD_WCLOUD
  2. Updates to enable various microphysics-related output in RRFS-MPAS, namely:
    • cloud-ice mixing ratio (isobaric and native levels)
    • graupel mixing ratio (isobaric and native levels)
    • ice-friendly aerosol number concentration (native levels)
    • water-friendly aerosol number concentration (native levels)

These updates run successfully within GSL's real-time RRFS-MPAS applications on Jet.

jaymes-kenyon and others added 5 commits December 5, 2024 16:30
@jaymes-kenyon
Remove the "GSD_" prefix from the "NCIFA_ON_HYBRID_LVL" shortname (nu…
f1b0a64 
…mber concentration of ice-friendly aerosols)
@jaymes-kenyon
Updates to enable various microphysics-related output in RRFS-MPAS, n…
4eb2896 
…amely:

- cloud-ice mixing ratio (isobaric and native levels)
- graupel mixing ratio (isobaric and native levels)
- ice-friendly aerosol number concentration (native levels)
- water-friendly aerosol number concentration (native levels)
@jaymes-kenyon
Temporary hard coding of imp_physics=8 for RRFS-MPAS, as required for…
e083330 
… brightness-temperature calculations in subroutine CALRAD_WCLOUD
@jaymes-kenyon
Updated flat file for RRFS-MPAS
42d6c26
@jaymes-kenyon
Merge branch 'NOAA-EMC:develop' into mpas_dev
d33cdec
@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 3, 2025 that may be closed by this pull request
RRFS-MPAS: Needed fixes and enhancements #1108
Closed
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon My UPP standalone test for MPAS is at /scratch1/NCEPDEV/stmp2/Wen.Meng/mpas_2024082112-after on Hera, please let me know if you see issues.

@jaymes-kenyon
Copy link
Contributor Author

Thanks, @WenMeng-NOAA! I think your results look as expected.

Within the WRFNAT12.tm00 file, I noticed three microphysics variables (NCONCD, PMTF, and PMTC) that had all zero values. This was because the RRFS netCDF file is somewhat old and is missing these arrays.

I will transfer a newer netCDF file onto Hera for future testing, but I think this test went as expected.

@jaymes-kenyon
Copy link
Contributor Author

A quick update: I transferred a newer RRFS-MPAS netCDF file onto Hera:
/scratch2/BMC/wrfruc/kenyon/sample/rrfs_mpas/2024112012/MPAS-A_out.2024-11-21_00.00.00.nc
It contains several new arrays, so it should be helpful for future UPP testing.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Please take a look at my new test with MPAS data you provided at /home/Wen.Meng/stmp2/mpas_2024112100 on Hera.

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Your latest test looks good—thanks for re-running it!

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Jan 7, 2025
@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA You may start the UPP RTs on R&D machines. There should be baseline changes with this PR.

@gspetro-NOAA
Copy link
Collaborator

gspetro-NOAA commented Jan 10, 2025 •
edited
Loading

@WenMeng-NOAA Will the baselines change for all tests or just a few? Or did you mean that there should be NO baseline changes? I'm not seeing any changes.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA You may start the UPP RTs on R&D machines. There should be baseline changes with this PR.

@gspetro-NOAA Sorry for the typo. I meant no baseline changes.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2 with no baseline changes.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA Please go head to approve this PR.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Jan 13, 2025
gspetro-NOAA
gspetro-NOAA approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs pass on Hera, Orion, and Hercules w/no baseline changes.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 965c6e3 into NOAA-EMC:develop Jan 13, 2025
3 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jan 13, 2025
Open
@jaymes-kenyon jaymes-kenyon deleted the mpas_dev branch January 13, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees
No one assigned
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RRFS-MPAS: Needed fixes and enhancements
4 participants
@jaymes-kenyon @WenMeng-NOAA @gspetro-NOAA @FernandoAndrade-NOAA