Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stable reference report #1963

Merged
merged 2 commits into from
Feb 29, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add a stable reference report
  • Loading branch information
scarlehoff committed Feb 29, 2024
commit 9d8e87606746f68b01737a6651dd15ed09f8748e
14 changes: 12 additions & 2 deletions .github/workflows/fitbot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ on:
env:
N3FIT_MAXNREP: 20 # total number of replicas to fit
POSTFIT_NREP: 16 # requested replicas for postfit
REFERENCE_SET: NNBOT-c0f99b7b3-2024-02-28 # reference set for vp
REFERENCE_SET: NNBOT-c0f99b7b3-2024-02-28 # reference set for exact results
STABLE_REFERENCE_SET: NNBOT-c0f99b7b3-2024-02-28 # reference set for last tag
CONDA_PY: 310
PYTHONHASHSEED: "0"

Expand Down Expand Up @@ -114,6 +115,14 @@ jobs:
--thcovmat_if_present
url=$(vp-upload output/ 2>&1 | grep https)
echo "REPORT_URL=$url" >> $GITHUB_ENV
vp-comparefits $RUNCARD $STABLE_REFERENCE_SET \
--title "Automatic check fit $RUNCARD" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can updated the title of both reports to include "most recent reference" and "stable reference" or something along those lines

scarlehoff marked this conversation as resolved.
Show resolved Hide resolved
--author bot \
--keywords run-fit-bot \
--thcovmat_if_present \
-o tagged_output
url=$(vp-upload tagged_output/ 2>&1 | grep https)
echo "REPORT_URL_STABLE=$url" >> $GITHUB_ENV
# write reminder
- name: Write summary on PR
uses: unsplash/comment-on-pr@master
Expand All @@ -124,7 +133,8 @@ jobs:
Greetings from your nice fit :robot: !
I have good news for you, I just finished my tasks:
- Fit Name: ${{ env.RUNCARD }}
- Fit Report: ${{ env.REPORT_URL }}
- Fit Report wrt master: ${{ env.REPORT_URL }}
- Fit Report wrt latest stable reference: ${{ env.REPORT_URL_STABLE }}
- Fit Data: ${{ env.FIT_URL }}

Check the report **carefully**, and please buy me a :coffee: , or better, a GPU :wink:!
Loading