[Algo] Adding Heap sort [Java] #509

pentalpha · 2018-10-31T00:25:02Z

Adds heap_sort.java, which includes an Java implementation of the Heap sort algorithm, using a custom Heap data structure.

About Heap sort: Heap sort can be thought of as an improved selection sort: like that algorithm, it divides its input into a sorted and an unsorted region, and it iteratively shrinks the unsorted region by extracting the largest element and moving that to the sorted region. The improvement consists of the use of a heap data structure rather than a linear-time search to find the maximum. (Wikipedia)

Closes #508

By submitting this pull request I confirm I've read and complied with the
below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the commit guidelines for this project.
My code follows the standard code structure.
This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

This commit adds heap_sort.java, which includes an Java implementation of the Heap sort algorithm, using a custom Heap data structure. Closes NITSkmOS#508

sangamcse · 2018-10-31T00:26:44Z

heap_sort/java/heap_sort.java

+            heap.removeMin();
+        }
+    }
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -10,7 +10,7 @@ heap.removeMin(); } } - + public static void main(String[] args) { int[] arr = new int[] {2, 3, 0, 4, -1, 34, 10, 12, 6, -10}; run_heap_sort(arr);

sangamcse · 2018-10-31T00:26:45Z

heap_sort/java/heap_sort.java

+            System.out.println(element);
+        }
+    }
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -18,7 +18,7 @@ System.out.println(element); } } - + private static class HeapMin { private int actualSize, maxSize; private int[] nodes;

sangamcse · 2018-10-31T00:26:46Z

heap_sort/java/heap_sort.java

+                return 0;
+            }
+        }
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -85,7 +85,7 @@ return 0; } } - + /** * Rises a heap element * @param i Element index

sangamcse · 2018-10-31T00:26:46Z

heap_sort/java/heap_sort.java

+                    int aux = nodes[parent(i)];
+                    nodes[parent(i)] = nodes[i];
+                    nodes[i] = aux;
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -98,7 +98,7 @@ int aux = nodes[parent(i)]; nodes[parent(i)] = nodes[i]; nodes[i] = aux; - + rise(parent(i)); } }

sangamcse · 2018-10-31T00:26:47Z

heap_sort/java/heap_sort.java

+                    }
+                }else if (leftChild(i) != 0){
+                    child = leftChild(i);
+                }    


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -127,7 +127,7 @@ } }else if (leftChild(i) != 0){ child = leftChild(i); - } + } //If there's a child node, try to switch node positions if(child > 0){

sangamcse · 2018-10-31T00:26:48Z

heap_sort/java/heap_sort.java

+                }else if (leftChild(i) != 0){
+                    child = leftChild(i);
+                }    
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -128,7 +128,7 @@ }else if (leftChild(i) != 0){ child = leftChild(i); } - + //If there's a child node, try to switch node positions if(child > 0){ if(nodes[child] < nodes[i]){

sangamcse · 2018-10-31T00:26:49Z

heap_sort/java/heap_sort.java

+                        int aux = nodes[i];
+                        nodes[i] = nodes[child];
+                        nodes[child] = aux;
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -135,7 +135,7 @@ int aux = nodes[i]; nodes[i] = nodes[child]; nodes[child] = aux; - + descend(child); } }

sangamcse · 2018-10-31T00:26:50Z

heap_sort/java/heap_sort.java

+                descend(1);
+            }
+        }
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -164,7 +164,7 @@ descend(1); } } - + } }```

sangamcse · 2018-10-31T00:26:51Z

heap_sort/java/heap_sort.java

+
+    }
+
+}


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: all.pyjava.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java +++ b/tmp/tmpf8ywa7q7/heap_sort/java/heap_sort.java @@ -167,4 +167,4 @@ } -}+}

pentalpha · 2018-10-31T01:04:39Z

There was some trailing whitespace on heap_sort.java, so I removed it in the second commit here.

pentalpha · 2018-10-31T10:40:05Z

Invalid? Why?

sangamcse · 2018-10-31T11:04:50Z

Go through the CONTRIBUTING guideline.

heap_sort.java: Add Java Heap sort algorithm

038fb88

This commit adds heap_sort.java, which includes an Java implementation of the Heap sort algorithm, using a custom Heap data structure. Closes NITSkmOS#508

sangamcse added process/pending_review bug Something isn't working difficulty/low hacktoberfest HACKTOBERFEST 2020 lang/Java type/algo size/S labels Oct 31, 2018

sangamcse reviewed Oct 31, 2018

View reviewed changes

heap_sort.java: Removes trailing white spaces from source code

7221432

sangamcse added the invalid This doesn't seem right label Oct 31, 2018

sangamcse closed this Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Algo] Adding Heap sort [Java] #509

[Algo] Adding Heap sort [Java] #509

pentalpha commented Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

sangamcse Oct 31, 2018

pentalpha commented Oct 31, 2018 •

edited

Loading

pentalpha commented Oct 31, 2018

sangamcse commented Oct 31, 2018

[Algo] Adding Heap sort [Java] #509

[Algo] Adding Heap sort [Java] #509

Conversation

pentalpha commented Oct 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pentalpha commented Oct 31, 2018 • edited Loading

pentalpha commented Oct 31, 2018

sangamcse commented Oct 31, 2018

pentalpha commented Oct 31, 2018 •

edited

Loading