Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input-number): use input event instead of change event #8989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jan 21, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8985

What is the new behavior?

  • 支持键入空字符串以将值置为 null
  • 在 input 事件发出时也会触发 ngModelChange

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Jan 21, 2025

This preview will be available after the AzureCI is passed.

@zorro-bot zorro-bot bot requested a review from vthinkxie January 21, 2025 11:03
@HyperLife1119 HyperLife1119 force-pushed the fix/number-input-change branch from 98f6fac to b07d22a Compare January 21, 2025 11:08
@HyperLife1119 HyperLife1119 marked this pull request as ready for review January 21, 2025 11:08
@HyperLife1119 HyperLife1119 self-assigned this Jan 21, 2025
@HyperLife1119 HyperLife1119 requested a review from Laffery January 21, 2025 11:09
@HyperLife1119 HyperLife1119 added this to the v19.1 milestone Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (2d8968d) to head (b07d22a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8989      +/-   ##
==========================================
- Coverage   91.93%   91.93%   -0.01%     
==========================================
  Files         555      555              
  Lines       19712    19719       +7     
  Branches     2946     2947       +1     
==========================================
+ Hits        18122    18128       +6     
  Misses       1264     1264              
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-input-number doesn't react on input, but only on change (that happens on blur)
1 participant