Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simkin biomass and productivity function updates #16

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Simkin biomass and productivity function updates #16

wants to merge 21 commits into from

Conversation

samsimkin
Copy link
Collaborator

No description provided.

@samsimkin
change biomass and productivity function names and add data tables
4169b8a
@samsimkin
some changes to calculateBiomass function
80d4d1a
@samsimkin
biomass and productivity function name changes
7256035
@samsimkin
small change
7560ba6
@samsimkin
biomass and productivity function updates
36fe0c9
@samsimkin
remove a few commented out lines
0c294d4
@samsimkin
fix site summaries by summing taxa within plots first
087d2ca
@samsimkin
exception handling for a line
7718867
@samsimkin
biomass and productivity function improvements
7b7a98a
@samsimkin
testthat tests now utilize single list input object but still yield e…
014f182 
…rrors with devtools check
@samsimkin
reduce size of static ancillary datasets and finished troubleshooting…
048d6ec 
… plots with missing metadata
@samsimkin
Merge branch 'dev' into biomass
38afe75
@samsimkin
biomass and productivity functions have testthat tests and no issues …
d278d24 
…in devtools check
@samsimkin
Merge branch 'biomass' of https://github.com/samsimkin/neonPlants int…
4a3e59f 
…o biomass
@samsimkin
split out herb and wood functions and made umbrella mass and prod fun…
267a7b5 
…ctions
@samsimkin
Merge branch 'dev' of https://github.com/NEONScience/neonPlants into …
31e3661 
…biomass
@samsimkin
add purrr for estimateProd and estimateMass functions
f1753e9
@samsimkin
Merge pull request #15 from samsimkin/biomass
eeed7e4 
Simkin biomass and productivity functions
@samsimkin
change mass functions to accept df inputs and enable inclusion of roo…
e5f60bb 
…ts in umbrella estimateMass function
@samsimkin
deal with ghost code
1986504
@samsimkin
fixed all devtools_check errors
2547114
@schafnoir
Copy link
Collaborator

Hi @samsimkin - I added a year column to the 'site' output table for the scaleRootMass function. Can you run the scaleRootMass function on the test data in the 'testdata' folder and let me know if the output is correct - i.e., it will work with your umbrella function?

Also, one more request - I see above that there is now a conflict with the DESCRIPTION file, likely because it was modified when I approved Katie's PR. To resolve, can you merge the dev branch into your dev_SMS branch?

Finally, I see you've got some tests developed, which is excellent. Have you run devtools::check() and all of these tests pass? And there are no other errors identified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsimkin @schafnoir