Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#24, #25) Add config for React + Typescript #26

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bryanpizzillo
Copy link
Member

Also updated the alpha publishing instructions.

Closes #24
Closes #25

- Created test ts React app
- Fixed a typo in eslint-config-react readme

Closes #25
@seyilonge-nci
Copy link

seyilonge-nci commented Dec 13, 2023

Linter errors below with current config/rules
Screenshot 2023-12-13 at 8 09 49 AM

Current eslint-plugin-testing-library version is 6.0.1, which has changes to rules noted in error above no-render-in-setup, and prefer-wait-for.
no-render-in-setup has been replaced with no-render-in-lifecycle, and prefer-wait-for was removed.

Migration guide: https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/migration-guides/v6.md

Current rules would have to be updated to reflect changes mentioned above.

@bryanpizzillo Would you like me to update the PR?

Also worthy of note that @nciocpl/eslint-config-react is currently on version 4.10.1 of eslint-plugin-testing-library which still has the old rules.

Tagging @arcepaul as well.

@seyilonge-nci seyilonge-nci force-pushed the ticket/25-react-typescript branch from 7280f5e to 189730e Compare December 15, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabler: Create Typescript React Linter Rules Change alpha branch name instructions to match semver
2 participants