Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: liquid water fraction and forcing variable names #743

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

scrasmussen
Copy link
Member

TYPE: enhancement

KEYWORDS: liquid water fraction, lqf, forcing variable names

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES:

  • Liquid water fraction: if liquid water fraction is present set snowbl = (1.0 - liqfrac) * pcp, otherwise set snow to 0.
  • Forcing variable names in namelist: forcing variable names T, Q, U, V, P, LW, SW can be passed to the model in the namelist.hrldas. In the namelist they take the form forcing_name_T. If the variables are not in the namelist they default to the normal hardcoded values that have been traditionally used.
  • module_lsm_forcing.F transitioned to Fortran 90 interfaces

TESTS CONDUCTED: Ran Amir's liquid water fraction testcase, tested new forcing variable in namelist.hrldas, ran Croton testcase

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

Michael Barlage and others added 7 commits March 22, 2024 10:52
…ing is read in, currently occuring for forcing types 1,2,6 when READFORC_HRLDAS is called
the SNOW variable as well. The liquid water fraction is now used to set SNOWBL if SNOW is not present.
…re now passed around to all other IO functions
@rcabell rcabell self-requested a review March 26, 2024 02:36
Copy link
Collaborator

@rcabell rcabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though GitHub Actions CI testing is failing, the regression suite passes on Derecho.

@rcabell rcabell merged commit ed44775 into NCAR:main Mar 27, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants