-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions New CI Comparison Method #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0b0972
to
0adfbfb
Compare
…t needed to install NetCDF, there were issues with the Conda installation - Github actions builds reference and candidate WRF-Hydro versions. - `make croton-{case}` will download Croton tarball if needed and setup Run directory - `make Run` will run testcase
c43c020
to
b95e0ef
Compare
…ions and python scripts are modified to run these functions then compare the output between reference and candidate builds
During debugging PR has changed a lot from original purpose DESCRIPTION OF CHANGES:
TESTS CONDUCTED: Current build is comparing reference to reference output since the CI will fail on the candidate code NOTES: checklist for acceptance and testing of this PR
|
- generating nwm_ana and nwm_long_range Makefile targets - adding more makefile targets - Bringing over xrcmp to test output of actions. Removing apt-install packages that aren't needed.
c0d9bf2
to
0a36750
Compare
Reference has been added back in, three github action reports to note
|
rcabell
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: PR HAS CHANGED A LOT, SEE COMMENTS LATER IN PR FOR CURRENT STATUS
TYPE: bug fix
KEYWORDS: CI, Google Drive, Croton Testcase
SOURCE: Soren Rasmussen, NCAR
DESCRIPTION OF CHANGES: Switch to gdown python package to download croton testcase. This new method is easier and better suppported.
TESTS CONDUCTED: Tested new lines in a test Python script and they succesfully download the Croton testcase.
NOTES: I believe the Docker image will need to be changed to make the Python package
gdown
a requirement so it downloads it. Will add that after submitting this pull request.