Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs environment to avoid Xarray bug #264

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Dec 18, 2024

PR Summary

This PR changes the documentation environment specification file to skip Xarray v2024.11.0 with the colormap specification / seaborn import bug. It intentionally doesn't change other environment specification files or the package requirements since this is a rather narrow bug that only impacts our examples because of how we specify colormaps and not something related to geocat-viz itself or broadly impacting Xarray. For this reason I didn't update the release notes either though I can if that is helpful for internal notes.

Closes #262

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald changed the title Update docs environment to avoid xarray bug Update docs environment to avoid Xarray bug Dec 18, 2024
@kafitzgerald kafitzgerald marked this pull request as ready for review December 18, 2024 18:41
@kafitzgerald kafitzgerald added bug Something isn't working upstream Related to upstream packages labels Dec 18, 2024
@kafitzgerald kafitzgerald requested a review from jukent December 18, 2024 18:42
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jukent jukent merged commit 74863a3 into NCAR:main Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Related to upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation has error messages for seaborn import
2 participants