Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and turn on image comparison testing in CI #257

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Dec 7, 2024

PR Summary

Updates tests to avoid hitting the seaborn import issue from xarray (see #256) and turns on image comparison testing in CI.

Doesn't alter our geocat-viz test coverage, but does avoid hitting the bug from upstream without requiring seaborn.

Closes #256
Closes #259

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald added the developer feature For development standardization / best practices / enhancement label Dec 7, 2024
@kafitzgerald kafitzgerald changed the title Update tests to avoid seaborn import issue from xarray Update tests and turn on image comparison testing in CI Dec 7, 2024
@kafitzgerald kafitzgerald marked this pull request as ready for review December 7, 2024 02:03
@kafitzgerald
Copy link
Collaborator Author

The only thing failing now is the link check which is addressed in #260.

@kafitzgerald kafitzgerald requested a review from jukent December 9, 2024 14:06
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I'm a little surprised that this is slightly more involved than in NCAR/geocat-examples#628

@kafitzgerald
Copy link
Collaborator Author

Great. I'm a little surprised that this is slightly more involved than in NCAR/geocat-examples#628

Yeah, there's a bit more info in the associated issues, but in short the way these projects are impacted is different. In geocat-examples, our examples leverage functionality that triggers the bug so I opted to adjust the environment file and disallow the impacted version. For geocat-viz, we can avoid the bug altogether by adapting our tests without reducing test coverage so I opted to do that instead.

@kafitzgerald kafitzgerald merged commit 42f6fc3 into NCAR:main Dec 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer feature For development standardization / best practices / enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image comparison testing not active for CI CI failures following Xarray 2024.11.0
2 participants