Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions #419

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Nov 11, 2024

I'm generally trying to follow the guidance at https://scientific-python.org/specs/spec-0000/

  • Require python >=3.9 (more permissive than above)
  • Require numpy >=1.24
  • Require scipy >=1.10
  • Update testing versions in tox.ini
    • Test python 3.9 - 3.13
    • Numpy 1.24 to 2.1
    • Use python 3.11 for build_docs and linkcheck (for newer versions we will need an updated pyoorb release)
    • matplotlib >= 3.8 to match python 3.9
  • Updated github workflows to use python 3.13 and 3.11.

Also reviewed python 3.9 change log: replaced deprecated typing.Tuple and typing.List with tuple[] and list[].

Copy link

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (9360983) to head (29f81f3).

Files with missing lines Patch % Lines
sbpy/dynamics/syndynes.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   84.61%   84.59%   -0.03%     
==========================================
  Files          92       92              
  Lines        8420     8419       -1     
==========================================
- Hits         7125     7122       -3     
- Misses       1295     1297       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Nov 12, 2024

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 105:27: E203 whitespace before ':'

Comment last updated at 2025-01-16 14:09:59 UTC

@mkelley mkelley added this to the v0.6 milestone Nov 12, 2024
@mkelley mkelley force-pushed the python-versions-2024.11 branch from fc2db3c to 10d0841 Compare November 12, 2024 15:25
@mkelley mkelley requested a review from hhsieh00 November 12, 2024 18:45
@mkelley
Copy link
Member Author

mkelley commented Nov 12, 2024

Ready for review!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To explain this change: Two files were merged and the other was deleted. I also added E203 to the ignore list because it conflicts with https://peps.python.org/pep-0008/#whitespace-in-expressions-and-statements

Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mkelley mkelley force-pushed the python-versions-2024.11 branch from e51896b to 29f81f3 Compare January 16, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants