-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions #419
base: main
Are you sure you want to change the base?
Update versions #419
Conversation
Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
- Coverage 84.61% 84.59% -0.03%
==========================================
Files 92 92
Lines 8420 8419 -1
==========================================
- Hits 7125 7122 -3
- Misses 1295 1297 +2 ☔ View full report in Codecov by Sentry. |
Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-16 14:09:59 UTC |
fc2db3c
to
10d0841
Compare
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To explain this change: Two files were merged and the other was deleted. I also added E203 to the ignore list because it conflicts with https://peps.python.org/pep-0008/#whitespace-in-expressions-and-statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
e51896b
to
29f81f3
Compare
I'm generally trying to follow the guidance at https://scientific-python.org/specs/spec-0000/
Also reviewed python 3.9 change log: replaced deprecated typing.Tuple and typing.List with tuple[] and list[].