Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scipy's romberg with quad. #412

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Sep 9, 2024

Romberg will be removed from scipy in v1.15.0.

Closes #399

Romberg will be removed from scipy in v1.15.0
Copy link

github-actions bot commented Sep 9, 2024

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (813fe61) to head (25f87dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files          88       88           
  Lines        8183     8183           
=======================================
  Hits         6808     6808           
  Misses       1375     1375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkelley mkelley requested a review from hhsieh00 September 9, 2024 14:59
@mkelley mkelley added this to the v0.6 milestone Sep 11, 2024
Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Codecov shows some uncovered code on the code diffs page, but gives a passing review on the main page + some of the ostensibly uncovered lines are related to package importing so looks like that might be considered an "uncoverable" line that the main Codecov report is happy to ignore.

@mkelley
Copy link
Member Author

mkelley commented Sep 21, 2024

If one visits the checks page https://github.com/NASA-Planetary-Science/sbpy/pull/412/checks?check_run_id=29881366244 and hits refresh, those uncovered lines disappear. I've searched the internet for a solution on how to refresh the "Files changed" tab, but I've not found a solution.

@mkelley mkelley merged commit 88ae68b into NASA-Planetary-Science:main Sep 21, 2024
10 checks passed
@mkelley mkelley deleted the remove-romberg-2024.09 branch September 21, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scipy.integrate.romberg is deprecated
2 participants