-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace scipy's romberg with quad. #412
Replace scipy's romberg with quad. #412
Conversation
Romberg will be removed from scipy in v1.15.0
Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 88 88
Lines 8183 8183
=======================================
Hits 6808 6808
Misses 1375 1375 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Codecov shows some uncovered code on the code diffs page, but gives a passing review on the main page + some of the ostensibly uncovered lines are related to package importing so looks like that might be considered an "uncoverable" line that the main Codecov report is happy to ignore.
If one visits the checks page https://github.com/NASA-Planetary-Science/sbpy/pull/412/checks?check_run_id=29881366244 and hits refresh, those uncovered lines disappear. I've searched the internet for a solution on how to refresh the "Files changed" tab, but I've not found a solution. |
Romberg will be removed from scipy in v1.15.0.
Closes #399