Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Astropy6rc [do not merge] #390

Closed
wants to merge 24 commits into from

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Nov 15, 2023

No description provided.

mkelley added 24 commits July 26, 2023 15:19
Edited the related decorators to use them.
* Mark additional doctests with required packages: synphot, scipy
* Rename utils.requires and utils.optional to utils.required_packages and utils.optional_packages
* Rename utils.decorators.optional to utils.decorators.optionally_uses
* Prefer use of unittest.mock.patch to test optional behavior when a package is available to the testing environment
@pep8speaks
Copy link

Hello @mkelley! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 260:80: E501 line too long (92 > 79 characters)

Line 46:80: E501 line too long (84 > 79 characters)

Line 17:80: E501 line too long (102 > 79 characters)

Line 19:80: E501 line too long (93 > 79 characters)

Line 10:1: E402 module level import not at top of file

Line 42:80: E501 line too long (92 > 79 characters)

Line 42:80: E501 line too long (82 > 79 characters)
Line 65:80: E501 line too long (80 > 79 characters)
Line 86:80: E501 line too long (86 > 79 characters)
Line 89:80: E501 line too long (85 > 79 characters)

Line 38:80: E501 line too long (108 > 79 characters)
Line 54:80: E501 line too long (82 > 79 characters)
Line 93:80: E501 line too long (112 > 79 characters)
Line 96:80: E501 line too long (85 > 79 characters)

Line 3:80: E501 line too long (80 > 79 characters)

Line 4:80: E501 line too long (80 > 79 characters)

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (36285d0) 76.84% compared to head (0cb020d) 86.89%.

Files Patch % Lines
sbpy/spectroscopy/tests/test_specgrad.py 55.55% 4 Missing ⚠️
sbpy/activity/gas/productionrate.py 80.00% 3 Missing ⚠️
sbpy/activity/gas/tests/test_core.py 90.90% 2 Missing ⚠️
sbpy/bib/core.py 75.00% 2 Missing ⚠️
sbpy/data/ephem.py 87.50% 2 Missing ⚠️
sbpy/data/obs.py 75.00% 2 Missing ⚠️
sbpy/data/phys.py 80.00% 2 Missing ⚠️
sbpy/photometry/core.py 71.42% 2 Missing ⚠️
sbpy/spectroscopy/sources.py 80.00% 2 Missing ⚠️
sbpy/activity/dust.py 80.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #390       +/-   ##
===========================================
+ Coverage   76.84%   86.89%   +10.05%     
===========================================
  Files          78       81        +3     
  Lines        6974     7096      +122     
===========================================
+ Hits         5359     6166      +807     
+ Misses       1615      930      -685     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkelley mkelley closed this Dec 5, 2023
@mkelley mkelley deleted the astropy6rc branch December 5, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants