Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MyBinder links to VEDA Binder #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented Dec 6, 2024

Closes

By

  • Change links to MyBinder to point at VEDA Binder
  • Add section explaining what Binder and VEDA Binder is

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@j08lue j08lue requested a review from wildintellect December 6, 2024 13:12
Copy link

github-actions bot commented Dec 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-188/
on branch gh-pages at 2024-12-06 13:15 UTC

Copy link
Contributor

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links seem to be good (I tested some), made some comments around the descriptions, nothing is a blocker.

@@ -67,7 +67,7 @@ Something like: public.ecr.aws/nasa-veda/pangeo-notebook:60b023fba2ca5f9e19d285c

To give the notebooks a standard look and feel we typically include the following sections:

- **Run this Notebook**: The section explains how to run the notebook locally, on VEDA JupyterHub or on [mybinder](https://mybinder.org/). There are several examples of what this section can look like in the template notebooks.
- **Run this Notebook**: The section explains how to run the notebook locally, on [VEDA JupyterHub](https://hub.openveda.cloud/), on [VEDA Binder](https://binder.openveda.cloud/), or on the public [MyBinder](https://mybinder.org/). There are several examples of what this section can look like in the template notebooks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the jupyterhub link be an internal reference to https://docs.openveda.cloud/nasa-veda-platform/scientific-computing/ ?
Or something that explains the Hub? Most people with hub access won't need the binder links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also concerned about link to https://binder.openveda.cloud if we don't have guardrails, since it might be abused by non-veda related work. @yuvipanda

@@ -15,12 +15,21 @@ VEDA scientific computing services provide scientists the resources they need to

VEDA promotes the use of JupyterHub environments for interactive data science. JupyterHub enables you to analyze massive archives of Earth science data in the cloud in an interactive environment that alleviates the complexities of managing compute resources (virtual machines, roles and permissions, etc).

### Limited access JupyterHub service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap Limited for a more positive term, like Sponsored or ?

@@ -31,7 +31,7 @@ The **Quickstarts** examples are further divided into two sections, which you ca

## How to run

Every notebook contains information about how to run it. Some can run on [mybinder](https://mybinder.org/) and all can run on the VEDA JupyterHub. See [VEDA Analytics JupyterHub Access](https://nasa-impact.github.io/veda-docs/veda-jh-access.html) for information about how to gain access.
Every notebook contains information about how to run it. Some can run on [Binder](https://binder.openveda.cloud/) and all can run on the [VEDA JupyterHub](https://hub.openveda.cloud/). See [VEDA Analytics JupyterHub Access](https://nasa-impact.github.io/veda-docs/veda-jh-access.html) for information about how to gain access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we pick a different term from Binder, that doesn't really explain what it is - but rather the technical tool that allows it. Maybe something like Trial or Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants