Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add / Improve French translation #45

Closed
wants to merge 3 commits into from
Closed

core: Add / Improve French translation #45

wants to merge 3 commits into from

Conversation

PingoLeon
Copy link

@PingoLeon PingoLeon commented Sep 18, 2024

Thanks for maintaining this project, I tweaked and added some translations that were uncorrect / missing.
Please note it may not be perfect, feel free to improve it.

Note : re-did the pull request so that there's no more than one commit for these small changes.

- few fixes in settings / body mass sections
@Myzel394
Copy link
Owner

Please note it may not be perfect, feel free to improve it.

Are you a native speaker of the French language?

Note : re-did the pull request so that there's no more than one commit for these small changes.

Okay no problem but it would also not be a problem to have more than one commit. More commits are actually better in most of the cases as they provide more granular control.

@PingoLeon
Copy link
Author

PingoLeon commented Sep 18, 2024

Are you a native speaker of the French language?

Yes I am. I said that because in French there's many ways to say the same things but with whole different words (e.g : "Paramètres supplémentaires" = "Réglages Additionnels") and one translation may be slightly more accurate than others depending on the context.

More commits are actually better in most of the cases as they provide more granular control.

That's true but in my case, it was some lines missed after a push, and a single commit for just a few typos seemed a bit excessive to me.

- added again the "\'" instead of "'" in the strings.xml file
@PingoLeon
Copy link
Author

PingoLeon commented Sep 18, 2024

My bad, missed those in the second commit, should be good now.

@PingoLeon PingoLeon closed this by deleting the head repository Sep 23, 2024
@PingoLeon
Copy link
Author

PingoLeon commented Sep 23, 2024

Didn't know that deleting my copy of the repo would close this PR, because I thought it had been merged.
Could you change the file with the content of https://github.com/Myzel394/NumberHub/pull/45/files (split view) please ?
Or should I re-open a PR ?

@Myzel394
Copy link
Owner

Myzel394 commented Sep 23, 2024

Please re-open it, this way you'll be authored correctly. Sorry, I wanted to merge after the ci:cd became green but forgot it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants