feat(inline-alert) - fix screen-reader causing extra scrollbar #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3416 |
github-actions
bot
requested review from
jason-evans-genesys and
thomas-c-dillon
321gillian
approved these changes
Jan 22, 2025
daragh-king-genesys
approved these changes
Jan 22, 2025
fix screen-reader stylings ✅ Closes: COMUI-3416
gavin-everett-genesys
force-pushed
the
feature/COMUI-3416
branch
from
2f0ed6e to
bb03887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket : https://inindca.atlassian.net/browse/COMUI-3416
Note :
So since the the
gux-sr-only-clipclass is positioned absolute it will look for the closest parent that has aposition:relativeset. In this case the span appears to position itself relative to another element at the bottom of the screen which produces the scrollbar. Could be the body element I am not sure ? To address this I think we should apply aposition: relativewithin thegux-screen-readerso that it will prevent the scrollbar and keep it within the component.I assume this will happen with other components also 🤔 I created this ticket so we can replace the
div class="gux-sr-only"classes in components with the screenreader component https://inindca.atlassian.net/browse/COMUI-3425