Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(form-field-file-beta): added new component #843

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] feat(form-field-file-beta): added new component #843

wants to merge 2 commits into from

Conversation

daragh-king-genesys
Copy link
Collaborator

added new component

✅ Closes: COMUI-3129

@github-actions GitHub Actions
Copy link

Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3129

daragh-king-genesys
daragh-king-genesys commented Jan 14, 2025
View reviewed changes
...omponents/stable/gux-form-field/components/gux-form-field-file-beta/gux-form-field-file.scss
@@ -0,0 +1,84 @@
@use '~genesys-spark/dist/scss/focus.scss';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will switch to using design tokens before removing [WIP] tag

@katie-bobbe-genesys
Copy link
Collaborator

I can't remove an added file using the keyboard. The 'X' isn't keyboard focusable

@katie-bobbe-genesys
Copy link
Collaborator

Should there be an indication in the component when it is a "multiple" vs "single" file upload? Also, in the case of a "multiple" file upload each time the "click to upload" is pressed, all the uploaded files are replaced.

@daragh-king-genesys
Copy link
Collaborator Author

Should there be an indication in the component when it is a "multiple" vs "single" file upload? Also, in the case of a "multiple" file upload each time the "click to upload" is pressed, all the uploaded files are replaced.

I will ask UX about this but how it is currently working is all native functionality. "multiple" is not visually indicated to the user.

@daragh-king-genesys
Copy link
Collaborator Author

I can't remove an added file using the keyboard. The 'X' isn't keyboard focusable

I will chat with you about this today. I thought that the usability of the component was worse when the button was keyboard nagitivable.

@daragh-king-genesys daragh-king-genesys force-pushed the feature/COMUI-3129 branch 3 times, most recently from 6d100ae to 93b6af6 Compare January 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katie-bobbe-genesys katie-bobbe-genesys katie-bobbe-genesys left review comments

@321gillian 321gillian Awaiting requested review from 321gillian

@jason-evans-genesys jason-evans-genesys Awaiting requested review from jason-evans-genesys

@MattCheely MattCheely Awaiting requested review from MattCheely

@jordanstith15 jordanstith15 Awaiting requested review from jordanstith15

@thomas-c-dillon thomas-c-dillon Awaiting requested review from thomas-c-dillon

@gavin-everett-genesys gavin-everett-genesys Awaiting requested review from gavin-everett-genesys

@dohajnal dohajnal Awaiting requested review from dohajnal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daragh-king-genesys @katie-bobbe-genesys