Feature/com UI 3394 form field number a11y check #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be accessible from a keyboard
github-actions
bot
requested review from
daragh-king-genesys and
thomas-c-dillon
| @@ -286,7 +286,6 @@ export class GuxFormFieldNumber { | |||
| <div class="gux-step-buttons-container"> | |||
| <button | |||
| class="gux-step-button" | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
@daragh-king-genesys I think the component is technically accessible, functionality matches the native component, but we've added in 2 buttons outside the input, which differs from the native number input. A sighted keyboard user should probably be able to access these. Technically accessible but maybe bad UX for a keyboard user?
My hunch is that it would fail an audit.
daragh-king-genesys
requested changes
Jan 20, 2025
daragh-king-genesys
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be accessible from a keyboard
While the component is technically accessible, I'm removing the
tabindex="-1"as a keyboard user may not know intuitively that the arrow keys can increment the component.