Added custom force feedback & fix periodic effects #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DIPERIODIC structure support for Sine/Square/Triangle/Sawtooth effects - Implement proper effect creation and parameter handling - Add effect cleanup and release in DestroyFFBEffect - Fix memory management for periodic effects - Add debug logging for effect lifecycle tracking - Fix effect persistence after device reattachment - Set correct periodic effect parameters (magnitude, period, phase) - Integrate with existing FFB effect management system - Fixed periodic effects initialization and updates - Added debug logging system for FFB effect creation and updates - Implemented proper force data array management - Added sample period handling based on device capabilities - Corrected effect parameter initialization sequence - Added proper cleanup for custom force resources - Improved error handling and debug reporting Technical details: - Implemented DICUSTOMFORCE structure with proper initialization - Added support for 10 magnitude inputs and sample period control - Fixed effect parameter synchronization between C++ and C# - Added proper memory management for force data arrays - Fixed E_INVALIDARG (0x80070057) error debugging - Added comprehensive debug logging system - Added proper cleanup in DestroyFFBEffect Known issues: - Custom force effect creation still returns E_INVALIDARG despite correct parameters - Device reports custom force support but rejects effect creation Note: Custom force implementation needs further investigation as the device reports support but rejects creation with proper parameters. A debug log will be created once it tested every time.
Added new info for hardware support as well as new features based on the latest code update
Added Demo App Preview Screenshot
- Updated the Demo App Screenshot - Added a notice
fixed Thrustmaster links
Updated hardware support items
Added some clarifications
## Updated the Unity C# part - Added periodic and custom effects - Fixed the way the native DLL was wrongly called the Update Effects functions - Added enhanced Ramp and Periodic parameters ## Updated ReadMe - Added additional info - Corrected typos ## Improved C++ Native code - Ramp effect now uses Start and End - Periodic effects now use frequency as well ### FFB Explorer utilizes the Ramp effect in the old simplified way ### Cleaned up the repository and added a Unity Sample Scene The Custom Effects keep returning the Wrong Parameters value, so I hid it in the Unity Inspector but the fundamentals and all of its functions are already in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DIPERIODIC structure support for Sine/Square/Triangle/Sawtooth effects
Implement proper effect creation and parameter handling
Add effect cleanup and release in DestroyFFBEffect
Fix memory management for periodic effects
Add debug logging for effect lifecycle tracking
Fix effect persistence after device reattachment
Set correct periodic effect parameters (magnitude, period, phase)
Integrate with existing FFB effect management system
Fixed periodic effects initialization and updates
Added debug logging system for FFB effect creation and updates
Implemented proper force data array management
Added sample period handling based on device capabilities
Corrected effect parameter initialization sequence
Added proper cleanup for custom force resources
Improved error handling and debug reporting
Technical details:
Known issues:
Note: Custom force implementation needs further investigation as the device reports support but rejects creation with proper parameters. A debug log will be created once it tested every time.