Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the links in README #136

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

SemyonSinchenko
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Using of links to raw.githubuser instead of links to file-history in git.
It fixes the problem with links (#135): https://semyonsinchenko.github.io/chispa/

Close #135

Links to git are not rendered in static websites. Links to
`raw.githubusercontent` should be used

 On branch 135-bad-png-links
 Your branch is up to date with 'mrpowers/main'.

 Changes to be committed:
	modified:   README.md
@SemyonSinchenko
Copy link
Collaborator Author

@fpgmaas Take a look, please

Copy link
Owner

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SemyonSinchenko SemyonSinchenko merged commit f051666 into MrPowers:main Aug 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are not rendered in GH pages
2 participants