propagate ignore_metadataflag #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jana-starkova Thank you for that contribution! May you, please, take a look on failing linters? |
|
@SemyonSinchenko sorry for that! I ran it locally just now, should be fixed |
SemyonSinchenko
approved these changes
Jul 31, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Fixes a bug in propagating the
ignore_metadataflag. This is an issue for nested struct columns, I've noticed it last week when using chispa to compare dataframes with nested structs. I believe it fixes #84 (the description is a bit vague)If an inner struct column of df1 has metadata and a column of df2 doesn't, despite passing the
ignore_metadataflag, the tests will fail. This PR fixes that.