Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests for multiple versions of pyspark #111

Merged
merged 2 commits into from
Jul 29, 2024
Merged

chore: add tests for multiple versions of pyspark #111

merged 2 commits into from
Jul 29, 2024

Conversation

fpgmaas
Copy link
Collaborator

@fpgmaas fpgmaas commented Jul 17, 2024

See e.g. here:

image

Proof that caching works as expected:

image

@fpgmaas fpgmaas linked an issue Jul 17, 2024 that may be closed by this pull request
Run unit tests for various version of Pyspark #109
Closed
@fpgmaas fpgmaas requested a review from SemyonSinchenko July 17, 2024 05:51
@fpgmaas fpgmaas added this to the v0.11.0 milestone Jul 20, 2024
SemyonSinchenko
SemyonSinchenko reviewed Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, thank you! One small point: may we also include on-dispatch option? Sometimes it is cool to have an ability to run tests-matrix for an arbitrary bracnh.

@fpgmaas
add tests for multiple versions of pyspark
95d188c 
fix

fix

try

fix

try

fix restore keys
@fpgmaas fpgmaas force-pushed the chore/test-pyspark branch from e7575ba to 95d188c Compare July 29, 2024 16:21
@fpgmaas fpgmaas requested a review from SemyonSinchenko July 29, 2024 16:23
SemyonSinchenko
SemyonSinchenko approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SemyonSinchenko SemyonSinchenko merged commit d876e24 into MrPowers:main Jul 29, 2024
15 checks passed
@Fixer38 Fixer38 mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Run unit tests for various version of Pyspark
2 participants
@fpgmaas @SemyonSinchenko