Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#325] Implement useSwiper #340

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[#325] Implement useSwiper #340

merged 2 commits into from
Apr 30, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Apr 18, 2024

#325

Changes

swiper2

Swiper 컴포넌트를 위한 useSwiper 훅입니다.
이해를 돕기위해 이미지와 주석을 상세히 작성했으니 확인 부탁드립니다.

시나리오

터치 start:

  • 처음 오프셋 저장
  • minOffsetX 계산

터치 move:

  • minOffsetXmaxOffsetX 안에 머무르도록 제한
  • offsetX 업데이트 (newOffsetX)

터치 end:

  • MIN_SWIPE_REQUIRED 보다 움직였는지 확인
  • 이동할 슬라이드의 인덱스 계산 후 이동

@2wheeh 2wheeh added the ui Something about UI label Apr 18, 2024
@2wheeh 2wheeh self-assigned this Apr 18, 2024
Base automatically changed from feature/issue-325/helpers to develop April 20, 2024 01:59
Copy link

@2wheeh 2wheeh force-pushed the feature/issue-325/use-swiper branch from 872d9bf to 0e0f649 Compare April 26, 2024 05:34
Copy link

@2wheeh 2wheeh changed the title [WIP][#325] Implement useSwiper [#325] Implement useSwiper Apr 26, 2024
@2wheeh 2wheeh marked this pull request as ready for review April 26, 2024 05:48
@2wheeh 2wheeh force-pushed the feature/issue-325/use-swiper branch from 0e0f649 to 21bd45f Compare April 26, 2024 06:18
Copy link

@2wheeh 2wheeh force-pushed the feature/issue-325/use-swiper branch from 21bd45f to f49b703 Compare April 26, 2024 06:19
Copy link

@2wheeh 2wheeh requested review from isutare412 and skgndi12 April 26, 2024 06:21
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@2wheeh 2wheeh merged commit 25a867a into develop Apr 30, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-325/use-swiper branch April 30, 2024 12:43
@2wheeh 2wheeh mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants