Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#233] Implement CreateReviewButton #255

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[#233] Implement CreateReviewButton #255

merged 2 commits into from
Mar 12, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Mar 11, 2024

#233

Changes

  • createReview api 요청을 위한 버튼입니다.
  • 요청 성공 시 추가된 리뷰 디테일 페이지로 이동합니다.
  • 비어있는 필드가 있는 경우, 위에 있는 요소 부터 에러 토스트를 표시하고 포커스 시킵니다. (참고: [#215] Introduce utils for creating review #216 (comment))

@2wheeh 2wheeh added the ui Something about UI label Mar 11, 2024
@2wheeh 2wheeh requested review from isutare412 and skgndi12 March 11, 2024 13:10
@2wheeh 2wheeh self-assigned this Mar 11, 2024
@github-actions GitHub Actions
Copy link

🚀 Storybook preview: https://65ef030dc99fd95135566369--cheerful-pothos-666fe1.netlify.app

@isutare412 isutare412 self-requested a review March 11, 2024 13:14
@github-actions GitHub Actions
Copy link

🚀 Storybook preview: https://65ef162893097c6089fe7f27--cheerful-pothos-666fe1.netlify.app

isutare412
isutare412 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@2wheeh 2wheeh merged commit b76a7ad into develop Mar 12, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-233/create-review-button branch March 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

@skgndi12 skgndi12 Awaiting requested review from skgndi12

Assignees

@2wheeh 2wheeh

Labels
ui Something about UI
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2wheeh @isutare412