Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#238] Add createReview #240

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Mar 11, 2024

#238

Changes

클라이언트 사이드에서 createReview api를 요청할 함수를 추가합니다.

실패 응답을 받은 경우 다음처럼 에러 메세지를 다루려합니다.

  • 개발자 도구의 콘솔에는 백엔드에서 돌려준 정보를 최대한 적어주고,
  • 유저 친화적인 에러 메세지를 던져서 UI 에서 토스트로 처리

@2wheeh 2wheeh requested review from isutare412 and skgndi12 March 11, 2024 01:41
@2wheeh 2wheeh self-assigned this Mar 11, 2024
@2wheeh 2wheeh added the ui Something about UI label Mar 11, 2024
Copy link

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@2wheeh 2wheeh merged commit b38ad23 into develop Mar 11, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-238/create-review-api branch March 11, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants