Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#219] Modify list comments API response #220

Merged
merged 2 commits into from
Mar 3, 2024
Merged

[#219] Modify list comments API response #220

merged 2 commits into from
Mar 3, 2024

Conversation

skgndi12
Copy link
Collaborator

@skgndi12 skgndi12 commented Mar 2, 2024 •
edited
Loading

Resolves #219

Changes

  • Modify schema to recognize paths regardless of trailing slash
    • /api/v1/comments (POST, GET)
  • Remove unnecessary paths from schema
    • /api/v1/comments/test (POST, GET)

@skgndi12 skgndi12 added enhancement New feature or request api labels Mar 2, 2024
@skgndi12 skgndi12 requested review from isutare412 and 2wheeh March 2, 2024 06:33
@skgndi12 skgndi12 self-assigned this Mar 2, 2024
@skgndi12 skgndi12 mentioned this pull request Mar 2, 2024
Closed
2wheeh
2wheeh reviewed Mar 2, 2024
View reviewed changes
api/generate/openapi.json Outdated Show resolved Hide resolved
isutare412
isutare412 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skgndi12 skgndi12 merged commit 55a598e into MovieReviewComment:develop Mar 3, 2024
1 check passed
@skgndi12 skgndi12 deleted the feature/issue-219/modify-list-comments-api-response branch March 3, 2024 02:03
@skgndi12 skgndi12 restored the feature/issue-219/modify-list-comments-api-response branch March 3, 2024 02:04
@skgndi12 skgndi12 deleted the feature/issue-219/modify-list-comments-api-response branch March 3, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2wheeh 2wheeh 2wheeh left review comments

@isutare412 isutare412 isutare412 approved these changes

Assignees

@skgndi12 skgndi12

Labels
api enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix list comments API to parse query parameter
3 participants
@skgndi12 @isutare412 @2wheeh