-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resources Section to community #192
base: main
Are you sure you want to change the base?
Conversation
@AristurtleDev I've used a slightly different way to you to insert the Donate button into the navbar (see screenshot above). Could you please look over the changes and let me know if I've not anything wrong and how it could be done better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, can't say I would have done anything different. There's some small things I've noticed now looking at it that I would suggest changing in a future PR, but these are things I did in the initial setup, nothing related to your PR.
@AristurtleDev But will these changes get around the issue you mentioned, or will this still hit the same problems you mentioned in the other PR? |
@AristurtleDev With this latest commit - 25986ee - I tried to add a new Resources menu option in the navbar. I've essentially copied the showcase.njk and related files to replicate that layout to take advantages of tags and everything the showcase page does. The problem I'm having is that it's somehow not picking up the data from resources.json file and it's contents. I'm hoping it's something you can spot from the code. I've tried everything and it still just looks like the showcase, but with no images :) |
Added Donate button and fixed Github icon: