Edit on more complex elements

[NicoMorenoSirius]

Summary by CodeRabbit

• Refactor
  • Improved handling of clickable elements for better consistency and robustness in edit mode.

[linear]

MOC-84 Can't edit the text of more complex elements

[coderabbitai]

Walkthrough

Walkthrough

The changes in editMode.ts focus on improving the handling of clickable elements. Enhancements include filtering text nodes more effectively and consistently casting elements as HTMLElement to ensure uniform handling. These modifications aim to streamline the interactions and functionality of editable elements within the application.

Changes

Files	Change Summary
apps/.../content/EditMode/editMode.ts	decorateClickable function now filters text nodes before processing. blockClickableElements and restoreNodes functions now cast elements to HTMLElement for consistent handling.

Sequence Diagram(s)

N/A

Poem

In the realm of clicks and taps, where nodes do thrive,
We filter and cast to keep our app alive.
With HTMLElement we now align,
Making sure our elements are all fine.
A touch of change, so small yet bright,
Keeps Mocksi-Lite's edit mode just right.
🎉🐇✨

---

Tip

Early access features: disabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3d08890 and ca32703.

Files selected for processing (1)

• apps/mocksi-lite/content/EditMode/editMode.ts (3 hunks)

Additional comments not posted (1)

apps/mocksi-lite/content/EditMode/editMode.ts (1)

215-216: Approve the type casting enhancements in blockClickableElements.

The explicit casting to HTMLElement is a good practice for handling properties consistently across different types of elements. Ensure that this change does not affect the UI behavior negatively.

Also applies to: 222-223

[coderabbitai]

Optimize filtering of text nodes in decorateClickable.

The use of replaceAll('\n', '') might be redundant if the intention is to trim whitespace. Consider simplifying the filter condition to improve performance and readability.

- const [textNode] = [...targetedElement.childNodes].filter(node => !!node.textContent?.trim().replaceAll('\n', ''));
+ const [textNode] = [...targetedElement.childNodes].filter(node => node.textContent?.trim());

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const [textNode] = [...targetedElement.childNodes].filter(node => !!node.textContent?.trim().replaceAll('\n', ''));
	const [textNode] = [...targetedElement.childNodes].filter(node => node.textContent?.trim());