Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Add record for source maps to manifest in development mode #181

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jonathankap
Copy link
Contributor

@jonathankap jonathankap commented Sep 12, 2024

Makes it so you can see the source when debugging the extension in development mode

Summary by CodeRabbit

  • New Features
    • Enhanced debugging capabilities by allowing access to JavaScript source maps for all URLs in development mode.

@jonathankap jonathankap requested a review from fitzk September 12, 2024 23:26
Copy link

coderabbitai bot commented Sep 12, 2024

Walkthrough

Walkthrough

The changes in this pull request involve an update to the vite.config.ts file, specifically enhancing the development mode of the application. A new entry has been added to the manifest.web_accessible_resources array, allowing access to JavaScript source maps located in the assets directory for all URLs. This modification is aimed at improving debugging capabilities without altering the application's core functionality.

Changes

File Change Summary
apps/mocksi-lite-next/vite.config.ts Added entry to manifest.web_accessible_resources for JavaScript source maps.

Assessment against linked issues

Objective Addressed Explanation
Improve debugging capabilities (undefined)

Possibly related issues

  • None identified.

Poem

In the code where rabbits hop,
Source maps now help us stop,
Debugging joy, a clearer view,
Hopping through the code, anew! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b17e803 and 663d5e2.

Files selected for processing (1)
  • apps/mocksi-lite-next/vite.config.ts (1 hunks)
Additional comments not posted (1)
apps/mocksi-lite-next/vite.config.ts (1)

53-59: LGTM!

The changes in the development case of the configuration are beneficial for debugging purposes. By adding a new entry to the manifest.web_accessible_resources array, developers can access the original source code of the JavaScript files when inspecting the application in a browser. This change enhances the debugging capabilities of the application in the development environment without affecting the overall control flow or logic.

The changes are also consistent with the PR summary and objectives, which aim to enhance the debugging experience of the extension when it is in development mode.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@elg0nz elg0nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@jonathankap jonathankap merged commit ea0adea into main Sep 13, 2024
2 checks passed
@jonathankap jonathankap deleted the extension_source_maps branch September 13, 2024 20:08
@coderabbitai coderabbitai bot mentioned this pull request Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants