Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot_rarefaction and remove plot_SNPie #161

Merged
merged 6 commits into from
Aug 5, 2017
Merged

Add plot_rarefaction and remove plot_SNPie #161

merged 6 commits into from
Aug 5, 2017

Conversation

dmcglinn
Copy link
Member

@dmcglinn dmcglinn commented Aug 4, 2017

The new function plot_rarefaction will be useful when one would like to visually compare two or more groups of rarefaction curves without censoring the comparison down to the smallest shared number of individuals as is done in plot.mob_out. Our todo list in #21 suggested we should remove plot_SNPie due to its dependence on rgl.

I also did other minor house keeping changes to the documentation. The function rarefaction returns just a zero if you feed it a vector of zeros.

@dmcglinn
Copy link
Member Author

dmcglinn commented Aug 4, 2017

Also I'm finding the Roxygen2 argument @inheritParams to be pretty useful for importing documentation for common arguments e.g.,(log). We should eventually try to use this more frequently internally within our package so we don't have to update documentation text in multiple places as the description of an argument changes.

@rueuntal
Copy link
Contributor

rueuntal commented Aug 5, 2017

Hey @dmcglinn does this PR require close review? I'm currently on the plane and won't be able to get to it until tomorrow. Feel free to merge if my input is not essential :)

@dmcglinn dmcglinn merged commit de2407e into MoBiodiv:master Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants