Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/test upload #54

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Feature/test upload #54

merged 3 commits into from
Apr 20, 2022

Conversation

astro
Copy link
Member

@astro astro commented Apr 19, 2022

Unfortunately I was not able to add cypress-file-upload like Cypress itself as recommended in #35. It is pulled in by devDependencies instead.

@astro astro requested a review from johannesloetzsch April 19, 2022 14:13
johannesloetzsch
johannesloetzsch approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@johannesloetzsch johannesloetzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works well and looks good to me :)

When keeping this fixtures, we should document the source+license to ensure we can prove that we don't infringe any copyright.

@astro astro merged commit 9a05497 into main Apr 20, 2022
@astro astro deleted the feature/test-upload branch April 20, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannesloetzsch johannesloetzsch johannesloetzsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astro @johannesloetzsch