fix(NetworkClient): Defer ApplySpawnPayload until OnObjectSpawnFinished #3968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works when there are less than 20 objects, but fails when there are more than 20.
public ArraySegment<byte> payload;
and that seems to be where the reader is getting lost, but SpawnMessage is a struct, and thus a value type, so I can't really make sense of why the payload isn't fully intact, unless it's not being written correctly.Original PR Description
==================
Virtually eliminates null refs with GO/NI/NB SyncVars by getting all objects into spawned dictionary before applying payloads and invoking hooks.
See ticket #3097
Test with PickupsDropsChilds example:
Before this PR
After the PR, all refs are valid.