Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: spatial hashing for InterestManagementBase #3380

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

imerr
Copy link
Contributor

@imerr imerr commented Feb 14, 2023

This is very much a work in progress and NEEDS changing before it is ready to merge (no runtime visibility changes and probably needs code cleaning up/commenting)

In my past testing, it's 4x faster for me
In @ninjakickja's recent testing ("simulation") it's 2.5x faster than the current one

Depends on/see #3379

@imerr
Copy link
Contributor Author

imerr commented Feb 14, 2023

Oh, the interest management test setup does not play well with this (from memory):

  • aoi.OnSpawned is not called since test identities are spawned before the aoi is assigned/created
  • the manual spawn assignments in the base NT add each identity twice

So that would need improving too

@imerr
Copy link
Contributor Author

imerr commented Feb 14, 2023

Ideally we'd just do a 1:1 non-breaking replacement for the normal spatial hashing here so users don't have to care, that should be doable?

@MrGadget1024 MrGadget1024 added the work in progress Need more time to decide. Nothing to do here for now. label Feb 15, 2023
@imerr imerr force-pushed the feat/ll_spatial_im branch from c1e04e6 to 561ca26 Compare February 16, 2023 11:25
@imerr imerr changed the title perf: spatial hashing for low level interest management perf: spatial hashing for InterestManagementBase Feb 16, 2023
@imerr imerr force-pushed the feat/ll_spatial_im branch from 561ca26 to 01604a9 Compare February 16, 2023 11:56
@imerr imerr force-pushed the feat/ll_spatial_im branch from 01604a9 to 3c5e363 Compare October 15, 2023 16:29
@imerr imerr force-pushed the feat/ll_spatial_im branch from 3c5e363 to 7a356e7 Compare January 29, 2024 15:37
@imerr imerr force-pushed the feat/ll_spatial_im branch from 7a356e7 to 338c063 Compare January 29, 2024 17:54
@imerr imerr requested a review from MrGadget1024 February 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Need more time to decide. Nothing to do here for now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants