Fix GeminiTool and FileSystemToolkit
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusaKhan16
changed the title
MusaKhan16
changed the title
GeminiTool and FileSystemToolkit
willbakst
approved these changes
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 399 399
Lines 13390 13388 -2
=========================================
- Hits 13390 13388 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #724 by modifying the implementation of
GeminiTool.tool_schemato correctly incorporate possible "required" parameters for the constructed schema required byFunctionDeclaration.This implementation also better aligns with other models and their respective implementations; however, it prioritizes correctness for the Gemini SDK via the documentation.