Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support-streaming-partial-tools #718

Merged
merged 12 commits into from
Nov 27, 2024

Conversation

koxudaxi
Copy link
Collaborator

closes: #711

@koxudaxi koxudaxi requested a review from willbakst as a code owner November 26, 2024 18:09
@koxudaxi koxudaxi marked this pull request as draft November 26, 2024 18:09
mirascope/core/base/stream.py Outdated Show resolved Hide resolved
mirascope/core/base/tool.py Outdated Show resolved Hide resolved
mirascope/core/base/tool.py Show resolved Hide resolved
mirascope/core/base/_call_factory.py Outdated Show resolved Hide resolved
@koxudaxi
Copy link
Collaborator Author

@willbakst
One more thing. mistral apparently always returns the complete tools in stream. In other words, we will not provide this option for mistral, since it will never be delta.

@koxudaxi
Copy link
Collaborator Author

@willbakst
Also groq seems to behave the same way as mistral.
In other words, this seems to be a special behavior only for openai.

@willbakst
Copy link
Contributor

@willbakst

Also groq seems to behave the same way as mistral.

In other words, this seems to be a special behavior only for openai.

I know for sure that Anthropic also supports this

@koxudaxi
Copy link
Collaborator Author

OK, I have confirmed Anthropic return partial tools.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4365d60) to head (514dba4).
Report is 13 commits behind head on release/v1.11.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/v1.11      #718   +/-   ##
===============================================
  Coverage         100.00%   100.00%           
===============================================
  Files                398       399    +1     
  Lines              13292     13390   +98     
===============================================
+ Hits               13292     13390   +98     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi marked this pull request as ready for review November 27, 2024 04:06
@koxudaxi koxudaxi requested a review from willbakst November 27, 2024 04:17
@willbakst willbakst changed the base branch from main to release/v1.11 November 27, 2024 05:36
@willbakst willbakst merged commit 4f2b7c3 into release/v1.11 Nov 27, 2024
7 checks passed
@willbakst willbakst deleted the support-streaming-partial-tools branch November 27, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming Partial Tools
2 participants