Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove delete logic #25

Merged
merged 22 commits into from
Nov 20, 2024
Merged

feat: Remove delete logic #25

merged 22 commits into from
Nov 20, 2024

Conversation

Pringled
Copy link
Member

No description provided.

@Pringled Pringled requested a review from stephantul November 19, 2024 15:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
vicinity/backends/annoy.py 0.00% 2 Missing ⚠️
vicinity/backends/pynndescent.py 0.00% 2 Missing ⚠️
vicinity/backends/faiss.py 0.00% 1 Missing ⚠️
vicinity/backends/hnsw.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_vicinity.py 100.00% <100.00%> (ø)
vicinity/backends/faiss.py 95.72% <0.00%> (ø)
vicinity/backends/hnsw.py 96.49% <0.00%> (-1.79%) ⬇️
vicinity/backends/annoy.py 94.93% <0.00%> (ø)
vicinity/backends/pynndescent.py 96.77% <0.00%> (ø)

... and 1 file with indirect coverage changes


🚨 Try these New Features:

vicinity/backends/pynndescent.py Outdated Show resolved Hide resolved
@Pringled Pringled merged commit 9f4d25b into main Nov 20, 2024
5 checks passed
@Pringled Pringled deleted the remove-delete-logic branch November 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants