Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory capacity counter #686

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

BenCheung0422
Copy link
Member

Self-explained by the title, this adds an inventory capacity counter, as demonstrated below:

Minicraft.Plus.2024-06-18.21-34-41.mp4

The position of the counter is shifted upward to prevent potential collision of the counter with the title of the menu. Also, it is placed at the corners for convenience to users, instead of other places below blocking more sights. And there is a background to prevent similar colors causing confusion from the background.

Though there might be potential issues when the menus are too long, caused by long lengths, but should be able to be fixed by #543.

This can let players know when they have the inventories full. Potentially related to #685.

@BenCheung0422 BenCheung0422 added the Improvement Ideas for changes to features or content. label Jun 18, 2024
@Litorom
Copy link
Member

Litorom commented Jun 19, 2024

Looks good but could be better aesthetically. Try making it use the menu background. Similar to how durability/arrows worked in Eye’s hotbar rewrite.

@BenCheung0422
Copy link
Member Author

I have changed the design of the counter, minorly using similar techniques as in #581, as demonstrated below:

Minicraft.Plus.2024-06-20.20-17-04.mp4

Upon the design, the color of the text changes according to the fullness of the inventory while the shape of the counter changes when the width of the text changes. The position is lock at the corners and a little overflow is preferred (when focused) as of the limited area of the inventory menu (when empty, or shortest width). The counter is expanded with the limit when focused, so they will not collide with another counter on the other menu at all.

Copy link
Member

@Litorom Litorom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new look is interesting. I approve.

@Litorom Litorom merged commit 1fcc0f1 into MinicraftPlus:main Jun 20, 2024
2 checks passed
@BenCheung0422 BenCheung0422 added UX/QoL and removed Improvement Ideas for changes to features or content. labels Aug 29, 2024
Makkkkus pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants