Simplify screenshot feature #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makkkkus
pushed a commit
that referenced
this pull request
Dec 5, 2024
(cherry picked from commit 71e739c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option to set the screenshot scaling is removed.
Instead, the same image as the canvas is captured and saved, so that the size of the screenshots will be the same as the canvas in the window at the moment.
The option was not saved in preferences, so the save file is not affected.
This can also prevent the excess of heap size caused by temporary image objects being created and garbage-collected while heap size is not shrunk by time whatever the size of free heap.
Please note that #587 can be used here for the notification of screenshots being saved.