Skip to content

Commit

Permalink
Remove ignored tests which produces warnings since serde 1.0.215
Browse files Browse the repository at this point in the history 
They are never will be implemented anyway. You need to implement deserialization manually
if you want two xs:choice fields in your struct.
  • Loading branch information
@Mingun
Mingun committed Nov 22, 2024
1 parent 10177b1 commit 65f57b2
Showing 1 changed file with 28 additions and 154 deletions.
182 changes: 28 additions & 154 deletions tests/serde-de-seq.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2792,83 +2792,20 @@ mod variable_name {
}
}

/// Tests are ignored, but exists to show a problem.
/// May be it will be solved in the future
mod choice_and_choice {
use super::*;
use pretty_assertions::assert_eq;

#[derive(Debug, PartialEq, Deserialize)]
struct Pair {
#[serde(rename = "$value")]
item: [Choice; 3],
// Actually, we cannot rename both fields to `$value`, which is now
// required to indicate, that field accepts elements with any name
#[serde(rename = "$value")]
element: [Choice2; 2],
}

#[test]
#[ignore = "There is no way to associate XML elements with `item` or `element` without extra knowledge from type"]
fn splitted() {
let data: Pair = from_str(
r#"
<root>
<first/>
<second/>
<one/>
<two/>
<three/>
</root>
"#,
)
.unwrap();

assert_eq!(
data,
Pair {
item: [Choice::One, Choice::Two, Choice::Other("three".into())],
element: [Choice2::First, Choice2::Second],
}
);
}

#[test]
#[ignore = "There is no way to associate XML elements with `item` or `element` without extra knowledge from type"]
fn overlapped() {
let data = from_str::<Pair>(
r#"
<root>
<one/>
<first/>
<two/>
<second/>
<three/>
</root>
"#,
);

#[cfg(feature = "overlapped-lists")]
assert_eq!(
data.unwrap(),
Pair {
item: [Choice::One, Choice::Two, Choice::Other("three".into())],
element: [Choice2::First, Choice2::Second],
}
);

#[cfg(not(feature = "overlapped-lists"))]
match data {
Err(DeError::Custom(e)) => {
assert_eq!(e, "invalid length 1, expected an array of length 3")
}
e => panic!(
r#"Expected `Err(Custom("invalid length 1, expected an array of length 3"))`, but got `{:?}`"#,
e
),
}
}
}
// choice_and_choice struct like
//
// #[derive(Deserialize)]
// struct Pair {
// #[serde(rename = "$value")]
// item: [Choice; 2],
//
// #[serde(rename = "$value")]
// element: [Choice2; 3],
// }
//
// cannot be implemented because both fields should be renamed to the
// same name $value. Derived implementation will never try to deserialize
// `element`
}

/// Deserialization of primitives slightly differs from deserialization
Expand Down Expand Up @@ -3932,83 +3869,20 @@ mod variable_name {
}
}

/// Tests are ignored, but exists to show a problem.
/// May be it will be solved in the future
mod choice_and_choice {
use super::*;
use pretty_assertions::assert_eq;

#[derive(Debug, PartialEq, Deserialize)]
struct Pair {
#[serde(rename = "$value")]
item: Vec<Choice>,
// Actually, we cannot rename both fields to `$value`, which is now
// required to indicate, that field accepts elements with any name
#[serde(rename = "$value")]
element: Vec<Choice2>,
}

#[test]
#[ignore = "There is no way to associate XML elements with `item` or `element` without extra knowledge from type"]
fn splitted() {
let data: Pair = from_str(
r#"
<root>
<first/>
<second/>
<one/>
<two/>
<three/>
</root>
"#,
)
.unwrap();

assert_eq!(
data,
Pair {
item: vec![Choice::One, Choice::Two, Choice::Other("three".into())],
element: vec![Choice2::First, Choice2::Second],
}
);
}

#[test]
#[ignore = "There is no way to associate XML elements with `item` or `element` without extra knowledge from type"]
fn overlapped() {
let data = from_str::<Pair>(
r#"
<root>
<one/>
<first/>
<two/>
<second/>
<three/>
</root>
"#,
);

#[cfg(feature = "overlapped-lists")]
assert_eq!(
data.unwrap(),
Pair {
item: vec![Choice::One, Choice::Two, Choice::Other("three".into())],
element: vec![Choice2::First, Choice2::Second],
}
);

#[cfg(not(feature = "overlapped-lists"))]
match data {
Err(DeError::Custom(e)) => {
assert_eq!(e, "invalid length 1, expected an array of length 3")
}
e => panic!(
r#"Expected `Err(Custom("invalid length 1, expected an array of length 3"))`, but got `{:?}`"#,
e
),
}
}
}
// choice_and_choice struct like
//
// #[derive(Deserialize)]
// struct Pair {
// #[serde(rename = "$value")]
// item: Vec<Choice>,
//
// #[serde(rename = "$value")]
// element: Vec<Choice2>,
// }
//
// cannot be implemented because both fields should be renamed to the
// same name $value. Derived implementation will never try to deserialize
// `element`
}

/// Deserialization of primitives slightly differs from deserialization
Expand Down

0 comments on commit 65f57b2

Please sign in to comment.