Refactor combo key logic #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
config/combo-key-refactor
branch
from
b6052e8 to
a1b7ed8
Compare
hashalite
approved these changes
Apr 1, 2024
MattSturgeon
commented
Apr 1, 2024
Hook into `setDown()` so that we can simplify `tick()`.
MattSturgeon
force-pushed
the
config/combo-key-refactor
branch
from
a1b7ed8 to
d8efdf9
Compare
hashalite
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooking into vanilla's
KeyMapping.setDown()allows use to greatly simplify the logic inFreecamComboKeyMapping.tick()without any change in behaviour.This is just small improvements I made while investigating #175. An actual fix for that will be separate, if I can even come up with a good solution...