Cosmetics/Refactoring #14870
Cosmetics/Refactoring #14870
Conversation
| @@ -147,7 +147,7 @@ let | |||
| MINA_COMMIT_DATE = "<unknown>"; | |||
| MINA_BRANCH = "<unknown>"; | |||
|
|
|||
| DUNE_PROFILE = "devnet"; | |||
| DUNE_PROFILE = "dev"; | |||
There was a problem hiding this comment.
I think it might need to depend on the concrete type of building one's doing, but that's a task for the future.
|
|
||
| let create_async (pk : Keypair.t) ~primary ~auxiliary ~prev_chals | ||
| ~prev_comms = | ||
| create_aux pk ~primary ~auxiliary ~prev_chals ~prev_comms | ||
| ~f:(fun pk auxiliary_input runtime_tables prev_challenges prev_sgs -> | ||
| ~f:(fun index witness runtime_tables prev_chals prev_sgs -> |
There was a problem hiding this comment.
I imagine the prev_chals change is related to homogeneity, right?
There was a problem hiding this comment.
Yes, it's just more homogenous w.r.t. the other call in the same file.
| let _one_hot_vector_to_num (type n) (v : n Per_proof_witness.One_hot_vector.t) : | ||
| Field.t = | ||
| let n = Vector.length (v :> (Boolean.var, n) Vector.t) in | ||
| let open Step_verifier in | ||
| Pseudo.choose (v, Vector.init n ~f:Field.of_int) ~f:Fn.id |
There was a problem hiding this comment.
Could have removed the function altogether, maybe ;-)
| @@ -2,7 +2,6 @@ open Pickles_types | |||
| open Hlist | |||
| open Import | |||
| open Impls.Step | |||
| open Step_verifier | |||
There was a problem hiding this comment.
Wow. Vicious ;-) Some people will not like that. I'm in favor, though
There was a problem hiding this comment.
I'm very much a fan of explicit imports, everything else is often really unreadable without some external tooling like IDE...
| in | ||
| Boolean.Assert.all vs ; chalss ) | ||
| in | ||
| [%log internal] "Step_compute_bulletproof_challenges_done" ; | ||
| let messages_for_next_step_proof = | ||
| let challenge_polynomial_commitments = | ||
| let module M = | ||
| H3.Map (Per_proof_witness) (E03 (Inner_curve)) | ||
| H3.Map (Per_proof_witness) (E03 (Step_verifier.Inner_curve)) |
There was a problem hiding this comment.
This here actually helps. We have so many Inner_curve identifiers
This reverts commit 7f4c46e.
|
!ci-build-me |
|
!ci-build-me |
|
The dependency cosmetic PR o1-labs/snarky#833 cannot be merged right now because their CI is broken. So I removed the |
|
!ci-build-me |
This PR is purely cosmetic refactoring not intended to have any logical changes.
Dependency:
Cosmetics/Refactoring o1-labs/snarky#833