Skip to content

Commit

Permalink
Fix the order of planning_adapters (moveit#511)
Browse files Browse the repository at this point in the history
* Update chomp_planner_tutorial.rst

Fix the order of planning_adapters.
Add TimeParameterization should be on the top of the list.
See moveit/moveit#2053

* Update planning_adapters_tutorial.rst
  • Loading branch information
tnaka authored Aug 10, 2020
1 parent 2ebb32e commit fa4595a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions doc/chomp_planner/chomp_planner_tutorial.rst
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ To achieve this, follow the steps:
<!-- load OMPL planning pipeline, but add the CHOMP planning adapter. -->
<include file="$(find panda_moveit_config)/launch/ompl_planning_pipeline.launch.xml">
<arg name="planning_adapters" value="
default_planner_request_adapters/AddTimeParameterization
default_planner_request_adapters/FixWorkspaceBounds
default_planner_request_adapters/FixStartStateBounds
default_planner_request_adapters/FixStartStateCollision
default_planner_request_adapters/FixStartStatePathConstraints
chomp/OptimizerAdapter
default_planner_request_adapters/AddTimeParameterization"
chomp/OptimizerAdapter"
/>
</include>
<!-- load chomp config -->
Expand Down
6 changes: 3 additions & 3 deletions doc/planning_adapters/planning_adapters_tutorial.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ To achieve this, follow the steps:
#. Open the ``ompl_planning_pipeline.launch`` file in the ``<robot_moveit_config>/launch`` folder of your robot. For the Panda robot it is this `file <https://github.com/ros-planning/panda_moveit_config/blob/melodic-devel/launch/ompl_planning_pipeline.launch.xml>`_. Edit this launch file, find the lines where ``<arg name="planning_adapters">`` is mentioned and change it to: ::

<arg name="planning_adapters"
value="default_planner_request_adapters/FixWorkspaceBounds
value="default_planner_request_adapters/AddTimeParameterization
default_planner_request_adapters/FixWorkspaceBounds
default_planner_request_adapters/FixStartStateBounds
default_planner_request_adapters/FixStartStateCollision
default_planner_request_adapters/FixStartStatePathConstraints
chomp/OptimizerAdapter
default_planner_request_adapters/AddTimeParameterization" />
chomp/OptimizerAdapter" />

#. The values of the ``planning_adapters`` is the order in which the mentioned adapters are called / invoked. Order here matters. Inside the CHOMP adapter, a :moveit_codedir:`call <moveit_planners/chomp/chomp_optimizer_adapter/src/chomp_optimizer_adapter.cpp#L169>` to OMPL is made before invoking the CHOMP optimization solver, so CHOMP takes the initial path computed by OMPL as the starting point to further optimize it.

Expand Down

0 comments on commit fa4595a

Please sign in to comment.