Fix [*] and ##[*] operator range minimums to be 0 #1192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the LRM,
[*] is an equivalent representation of [*0:$]
(1800-2023 p411 16.9.1) and##[*] is used as an equivalent representation of ##[0:$]
(1800-2023 p400 16.7).With the current master build of slang (170ad7b),
[*]
and[*0:$]
produce the following ast json respectively:and
##[*]
and##[0:$]
produce the following respectively:These should all have the same
min
value of 0, but these cases weren't being handled correctly. This patch adds the special casing needed for these two scenarios, and the output now has"min": 0
for all cases.An alternative approach could be to set the default
SequenceRange::min
value to 0, but I wasn't sure if other code relies on it being 1.