Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model Version Text #2727

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

rwilson504
Copy link
Contributor

The pac pages upload and download commands have a --modelVersion switch. The existing documentation said to use Enhanced or Standard as the command line values but those are inaccurate. The values are 1 for Standard and 2 for Enhanced. This update clarifies that.

Copy link

Learn Build status updates of commit 1407969:

✅ Validation status: passed

File Status Preview URL Details
power-platform/developer/cli/reference/pages.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@JimDaly JimDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwilson504

Thanks for your contribution, however, please note the comment at the top of this article that says:

<!-- 
Do not edit this file. 
This file is generated by a program and any changes will be overwritten when this topic is re-generated.
Use the include files to add additional content to this topic.
-->

If I accept your changes, they will be overwritten the next time the docs are generated.

Please use the appropriate include file to make these changes:

includes/pages-download-remarks.md
includes/pages-upload-remarks.md

I will get the review of the product team before I merge these changes. They may choose to simply make the help content more specific, achieving the same result.

@rwilson504
Copy link
Contributor Author

@JimDaly, the original content I updated on this page is not within the pages you referenced, it's only on the pages.md file.

includes/pages-download-remarks.md
includes/pages-upload-remarks.md

Is there another place it's coming from?

Thanks,

Rick

@JimDaly
Copy link
Contributor

JimDaly commented Jan 9, 2025

@JimDaly, the original content I updated on this page is not within the pages you referenced, it's only on the pages.md file.

includes/pages-download-remarks.md includes/pages-upload-remarks.md

Is there another place it's coming from?

Thanks,

Rick

Yes. It comes from the PAC CLI help system. When you use the help command, the text you see in the UI is used to generate the original text. Unfortunately, that isn't open sourced.

In the documentation we can add examples and remarks. The files in the includes folder contain text that is a starting point. Just add what you feel will be valuable to the respective file in the includes folder. These are the files for Remarks. They include the additional content related to the pages upload and pages download commands:

includes/pages-upload-remarks.md
includes/pages-download-remarks.md

As I get this reviewed by the team, I will recommend that they update the help text. This PR will show them how it helps.

Copy link

Learn Build status updates of commit fd6f829:

✅ Validation status: passed

File Status Preview URL Details
power-platform/developer/cli/reference/includes/pages-download-intro.md ✅Succeeded
power-platform/developer/cli/reference/includes/pages-upload-intro.md ✅Succeeded
power-platform/developer/cli/reference/pages.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 9f328f8:

✅ Validation status: passed

File Status Preview URL Details
power-platform/developer/cli/reference/includes/pages-download-intro.md ✅Succeeded
power-platform/developer/cli/reference/includes/pages-upload-intro.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@rwilson504
Copy link
Contributor Author

@JimDaly , I updated the intro includes to include the --modelVersion option in the example instead of putting it in the remarks. This better aligns with what is already in the articles which were linked to in the remarks sections. https://learn.microsoft.com/en-us/power-pages/configure/power-platform-cli-tutorial#step-3-download-website-content.

That along with updates the product team could make in the CLI help files should make the values for this option clear to users.

Thanks,

Rick

@JimDaly JimDaly merged commit 8b33cfb into MicrosoftDocs:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants