Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution.md #2684

Closed
wants to merge 1 commit into from
Closed

Conversation

ericregnier
Copy link
Contributor

Updated correct behavior on pac solution import with specifying when SolutionPackageType is Both

Updated correct behavior on pac solution import with specifying when SolutionPackageType is Both
Copy link

Learn Build status updates of commit afa89bf:

✅ Validation status: passed

File Status Preview URL Details
power-platform/developer/cli/reference/solution.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@JimDaly
Copy link
Contributor

JimDaly commented Sep 24, 2024

@ericregnier

Thanks for this.
Please see the comment at the top of this article:

<--
Do not edit this file.
This file is generated by a program and any changes will be overwritten when this topic is re-generated.
Use the include files to add additional content to this topic.
-- >

To add this detail where you specified, the PAC CLI team will need to add it to the /help content.

Otherwise, please add it to the include files for the pac solution import command. See https://github.com/MicrosoftDocs/power-platform/blob/main/power-platform/developer/cli/reference/includes/solution-import-remarks.md

Copy link
Contributor

@JimDaly JimDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comments.

@petrochuk & @laneswenka
You may want to just add this to the /help content for the import solution command.

@@ -435,7 +435,7 @@ Max asynchronous wait time in minutes. The default value is 60 minutes.

#### `--path` `-p`

Path to solution zip file. If not specified, assumes the current folder is a cdsproj project.
Path to solution zip file. If not specified, assumes the current folder is a cdsproj project. If `SolutionPackageType` in cdsproj file is set to `Both`, the managed solution is used by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be edited manually. It will be overwritten next time docs are generated.

@ericregnier
Copy link
Contributor Author

Updated correct behavior on pac solution import with specifying when SolutionPackageType is Both

@JimDaly thanks and noted. I submitted another PR remark file instead. Cheers!

@JimDaly
Copy link
Contributor

JimDaly commented Sep 25, 2024

Closing this in favor of #2685

@JimDaly JimDaly closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants