Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified the purpose of the 'Convert to Managed' parameter on the 'Import Solution' task #2443

Closed
wants to merge 2 commits into from

Conversation

parvezghumra
Copy link

No description provided.

Copy link

Learn Build status updates of commit d32dc31:

✅ Validation status: passed

File Status Preview URL Details
power-platform/alm/devops-build-tool-tasks.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 8aade08:

✅ Validation status: passed

File Status Preview URL Details
power-platform/alm/devops-build-tool-tasks.md ✅Succeeded
power-platform/developer/cli/reference/solution.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@parvezghumra
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

@JimDaly JimDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't edit the developer/cli/reference/solution.md file.
As noted at the top of the file:

<!-- 
Do not edit this file. 
This file is generated by a program and any changes will be overwritten when this topic is re-generated.
Use the include files to add additional content to this topic.
-->

Please remove this change.

For this to change, the PAC CLI team must change the help text for the command. The new description will appear when the PAC CLI is updated and it will align with the description in the /help command.

@JimDaly
Copy link
Contributor

JimDaly commented Feb 9, 2024

@phecke and @marcelbf
The description for ImportSolution message ConvertToManaged property is found in our reference content too.

See:

Web API also has ImportSolutionAsync Action with this property.

All these descriptions should be aligned.

Also, the remarks for the pac solution import command has this in the Remarks section: convert-to-managed

The convert-to-managed parameter doesn't take an unmanaged solution and import it as managed. This parameter allows a managed solution that is being imported into an environment convert unmanaged components to managed.

If this flag isn't explicitly set, the solution system will fail the import request because managed layers can't go on top of unmanaged base components. This switch allows the solution import to succeed and the net result is that the inbound managed solution will be the base layer for each of these components – the components in the destination environment are converted from being an unmanaged component to being a managed component.

Seems like current 'short description' for convert-to-managed is incorrect.

@parvezghumra you are proposing:

Specify whether to convert into managed any unmanaged versions of objects found in the target environment that exist in the solution being imported in a managed state.

Is the description used in other places equivalent to your intent? Or are you trying to describe a different behavior?

If it is the equivalent, please align your change with those existing descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants