-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical Flip #13
base: master
Are you sure you want to change the base?
Conversation
Arcade-QBert.sv
Outdated
|
||
video_resync video_resync | ||
( | ||
.clk(clk_sys), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use clk_40 as clock for video_resync instead of clk_sys. Ultimately ce_pix is generated by clk_40 which is also the video clock: clk_40->cnt3[1]=clk_10->clk_5=ce_pix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that part was untested by now :) i removed from the repo until tested. I only wanna to push the vflip fix.
Thanx for the advice.
@@ -528,7 +528,7 @@ mylstar_board mylstar_board | |||
.rom_index(ioctl_index), | |||
|
|||
.vflip(status[11]), | |||
.hflip(1'b0) | |||
.hflip(status[11]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I had voluntarily disabled vflip because it was causing problems with QBert. Are you sure it works? Maybe you can post the RBF to the "test-builds" channel to get some feedback about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I was talking about hflip!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have the rbf in the fork https://github.com/neurorulez/Arcade-QBert_MiSTer/blob/master/releases/Arcade-QBert_20211123.rbf
and someone tested in the forum
https://misterfpga.org/viewtopic.php?p=38011#p38011
i dont have a CRT now to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested the rbf @neurorulez posted above in my cocktail cab and can confirm the vertical flip option is working correctly now. During gameplay Qbert is offset from the top of the cubes, which I don't know if existed before the flip fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that was the problem I was referring to. We need to fix it at the same time.
Fix Issue #3 for the vertical flip